kiltedup - 6 months ago

Evening,

Just did a completely fresh install on a droplet on DO and having a bang head against the wall time with it.

Installing with latest composer.json, the text-field-type comes in at 2.2.4 so misses the semi colon fix in 2.2.5 so I'm curious as to what I need to update to pull that in.

That aside, tabs in forms are completely toast with this install. e.g. Go to add a User and when you click the 'Profile' tab, nothing happens .... well other than the profile anchor being added to url ( admin/users/create becomes admin/users/create#tab- )

Anything going on at moment thats causing all this. Was showing someone how easy it was to spin up a new install and start using so wondering if there are any tips on fixing above so I can convince them it really is :-)

Ta

Dave

ryanthompson - 6 months ago

Couple contributions looks like messed things up.

I'll take care of this real quick.

Good news is tests are running and I am working on adding tests and browser tests as well so this can be avoided soon with automated tests.

ryanthompson - 6 months ago

Also looks like the text-field_type webhook on Github error'd out last time. Forced an update and it's good to go.

ryanthompson - 6 months ago

Fixed up - sorry about that. Back to hardcore manually testing PRs :-(

kiltedup - 6 months ago

Thanks Ryan - that quick update is much appreciated. No need to apologise :-) Right - back to showing why person I was showing Pyro should ditch their 3 w***press sites !!!!!

fryiee - 6 months ago

This was due to tab autoloading support not supporting both key methods. I've added a PR to make sure it works on both.