Thoughts on Settings Module and Laravel configuration?
ryanthompson - 11 months ago
It's been a few times during the release cycle that the settings module have had fields tied to the Laravel mailer and debugger amongst other things. In and then out and then finally again for the release.
What do you guys think about removing settings for email driver / host / etc and debugging from the system settings? Instead, you would set them like a native Laravel app. This way they are picked up properly during Laravel's boot cycle.
Here's what I am concerned with.
I have to mimic a lot of Laravel's service provider work in order to set up a NEW mailer with the provided settings.
Currently, I have discovered that this doesn't properly work either. Unless you of course configure Laravel natively through config / env.
It's none of the users business.
This had previously been my primary concern. It's no business of a person in the control panel to configure the app(s) email settings / debug settings. That's up to a qualified dev / person. Separation of concerns here.
Let Laravel be Laravel.
I feel like this has been overstepping the boundaries between Laravel and PyroCMS and kinda stepping on toes as a result.
You would just configure email settings with config files / .env just like you would any other Laravel application.