FormHandler success message when not successful

FormHandler success message when not successful

Created 7 years ago by emergingdzns

I've got a form builder and a handler on a stream. However, when the user saves the form, attempting to enter an email address that's already associated with an account or a mismatched password etc (basically failed validation) it returns back as expected but it's throwing the "success" message at the top before the validator error message.

In the CustomerFormBuilder.php file I have the following (among others):

    protected $options = [
        'success_message'   => 'Customer Account Information Saved',
    ];

In the form, I have added a password field, a confirm password field and an email field. This way when the customer fills in their info, they are able to be added as a user. In my CustomerFormHandler.php file I have it setup like this (please don't give me crap about using the Input class. I know... I'm supposed to use Request. I did this before I really understood that. I'll update eventually):

class CustomerFormHandler
{
    public function handle(CustomerFormBuilder $builder,
                            Redirector $redirect,
                            UserRepositoryInterface $users,
                            Repository $config,
                            UserActivator $activator,
                            UserAuthenticator $authenticator,
                            RoleRepositoryInterface $roles) {
        if (!$builder->canSave()) {
            return;
        }
        if (Input::has('createAccount') && Input::get('createAccount') == "yes" && !@Auth::user()) {
            $username = $display_name = str_replace(['.','@'], ['_','_'], Input::get('email'));
            $email = Input::get('email');
            $password = Input::get('password');
            $confirm_password = Input::get('confirm_password');

            // verify passwords match
            $validator = Validator::make([
                    'email' => $email,
                    'password' => $password,
                    'password_confirmation' => $confirm_password
                ],[
                    'email' => 'required|email|unique:users_users,email',
                    'password' => 'required|confirmed'
                ],[
                    'email.required' => 'Email address is required',
                    'email.email' => 'Email address is not valid',
                    'email.unique' => 'The email address entered is already registered. Click Edit on Step 1 and Login to use that account.',
                    'password.required' => 'The password and confirm password fields are both required',
                    'password.confirmed' => 'The password and confirmation do not match'
                ]);

            if ($validator->fails()) {
                return Redirect::back()->with('error',$validator->errors()->all())->withInput();
            }
            $user = $users->create([
                'username' => $username,
                'display_name' => $display_name,
                'email' => $email,
                'password' => $password
            ]);

            $activator->force($user);

            $memberRole = $roles->findBySlug('members');
            $user->attachRole($memberRole);

            $authenticator->login($user);
            $this->transmit(new UserHasRegistered($user));
        }

        $builder->saveForm();
        $entry = $builder->getFormEntry();
    }
}

So in the code above, it returns back when the validator fails... BEFORE it does the saveForm() function. So why is it throwing a success message when it returns back?