My theme breaks after updating to newer version of Pyrocms

william - 1 week ago

I use elixir to compile my scss files to css. I copy the file to public/css/theme.css. I use asset_path to pull it into my theme.

The error message:

Symfony\Component\Debug\Exception\FatalErrorException thrown with message "Method Illuminate\View\View::__toString() must not throw an exception, caught Twig_Error_Syntax: Unclosed comment in "storage/streams/sr//support/parsed/d179e771c0b31610bd6ba14c62e59056.twig" at line 14."

Stacktrace:
#0 Symfony\Component\Debug\Exception\FatalErrorException in vendor/laravel/framework/src/Illuminate/Filesystem/Filesystem.php:111

Method Illuminate\View\View::__toString() must not throw an exception, caught Twig_Error_Syntax: Unclosed comment in "storage/streams/sr//support/parsed/d179e771c0b31610bd6ba14c62e59056.twig" at line 14.

This is the code i located that breaks it..

#mobilemenu
{
    @include media-breakpoint-up(xl) {
        width: 400px;
    }
}

william - 1 week ago

Before updating to the newest version of pyrocms, i had no issues at all.

ryanthompson - 1 week ago

SO it used to be that any parsing issues were caught / ignored because Twig had issues with minification which we could not bump up in the order for Assetic. NOW.. things are a little different so it's not try/catching anymore. But I can surely revert that part.

Has to do with minifying, compiling, and parsing syntaxes :-(

Give me 2 minutes I'll add a try catch back in.

william - 1 week ago

Your latest fix to this problem made it work!